Conversation
|
Hi @symious, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user symious" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
❗ This change is not yet ready to be integrated. |
|
/signed |
|
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
bridgekeeper
bot
removed
oca
1 participant
mvn archetype:generatewill be using the default "0.5" version, but it's not compatible with new JDKs (JDK21 can not run successfully in my case).This change is to specify the version to the latest JMH arch version as "1.37", tested works well both with JDK8 and JDK21.
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/166/head:pull/166$ git checkout pull/166Update a local copy of the PR:
$ git checkout pull/166$ git pull https://git.openjdk.org/jmh.git pull/166/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 166View PR using the GUI difftool:
$ git pr show -t 166Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/166.diff
Using Webrev
Link to Webrev Comment